Disable yjs connecting status in tests2 #2111

[mstrofbass]

Updates the OfflineStatusStore to use a timeout of 0 before going into offline mode, thus hiding the loading screen immediately when we're in the e2e tests. The corresponding sleep time is removed from the e2e tests setup function, shaving a significant amount of time off of their runtime.

Closes #2111

[mstrofbass]

I'm not sure how safe the use of navigator.webdriver is here since there may be legitimate reasons that we want to use automation and have the site behave as normal. Maybe we can set a variable on the window that we can check?

[raineorshine]

Thanks, looks good! You can make isE2E a constant variable rather than a function, since it is always determined synchronously on startup and never changes.

Since we're only using 'navigator.webdriver` for e2e tests now, and it's trivial to search for all instances in the codebase in the future, then I think it's not necessary to create another of abstraction at this time.

[raineorshine]

Going to merge this now since it offers such a dramatic improvement to the test performance, and will help the rest of the team immediately!