Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandacss: convert thought related components #2449

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

yangchristina
Copy link
Collaborator

@yangchristina yangchristina commented Oct 9, 2024

8af4755 fixes e31045c line 19 (extra comma inside style)

  • This doesn't seem like a regression, since when running main, the border still shows up. However I have confirmed that adding the comma is causing the puppeteer tests to fail, but it looks like the expected test is wrong (doesn't have the border)

The left is missing a border, but a border should exist
font-size-18-default-initial-load-1-diff
@trevinhofmann I think this may be a problem with the test, I'm not too familiar with how these snapshot tests work, so I was wondering if you could give me some advice on how to deal with this?

25ce846 fixes 65ac386 removed line 107 of components/Bullet.tsx (fix selector in puppeteer test) (regression in load a child after a parent is expanded test, causing it to always pass)

@yangchristina yangchristina marked this pull request as ready for review October 11, 2024 17:44
@trevinhofmann trevinhofmann self-assigned this Oct 12, 2024
@yangchristina
Copy link
Collaborator Author

Interesting, I didn't change anything, just merged with main, and all the tests are passing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants