Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PROTOSpawner Feature #818

Open
ygoumaz opened this issue Jul 7, 2023 · 2 comments · May be fixed by #819
Open

New PROTOSpawner Feature #818

ygoumaz opened this issue Jul 7, 2023 · 2 comments · May be fixed by #819
Labels
enhancement New feature or request
Milestone

Comments

@ygoumaz
Copy link
Contributor

ygoumaz commented Jul 7, 2023

From version 2024.0.0, importing URDF and Xacro files will be deprecated (see #815). It is now already possible to import robot strings using the Ros2Supervisor (which uses the importMFNodeFromString API function).

However, this feature is very limited as PROTOs can't be imported by providing a file path and can't be declared in the robot string without declaring their URLs as IMPORTABLE in the world file.

Implementation blueprint

The new PROTOSpawner node should replace the current URDFSpawner. As argument, it should take a list of PROTO URLs to add to the IMPORTABLE list and a node string with a list of URLs. The current robot_string service created by the Ros2Supervisor should be enhanced to be called with those arguments.

The Ros2Supervisor (in the service callback) is then responsible to add the URLs to the IMPORTABLE list (using a new API function described in cyberbotics/webots#6316). In the same way as the URDFSpawner callback, it must update intern URLs and copy PROTO files (if needed) to the correct location in function of the platform (WSL, macOS, Linux).

Finally, the robot string should be imported.

Detailed tasks are given in the open PR #819.

@ygoumaz ygoumaz added the enhancement New feature or request label Jul 7, 2023
@ygoumaz ygoumaz added this to the 2024.0.0 milestone Jul 7, 2023
@ygoumaz ygoumaz self-assigned this Jul 7, 2023
@ygoumaz ygoumaz linked a pull request Jul 21, 2023 that will close this issue
14 tasks
@ygoumaz ygoumaz removed their assignment Jul 26, 2023
@francocipollone
Copy link

Hey there! It is expected to be part of the 2024 release right?

May I ask why deprecating support for spawning URDFs (URDFSpawner)?

@omichel
Copy link
Member

omichel commented Feb 29, 2024

We want to replace URDF spawning with PROTO spawning which is way simpler to handle and is causing less issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants