pg connector pass client options #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doodlesbykumbi
force-pushed
the
pg-pass-client-options
branch
from
8a2131b to
da252f1
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
diverdane
previously approved these changes
Jan 13, 2022
| @@ -23,6 +23,7 @@ type SingleUseConnector struct { | |||
| connectionDetails *ConnectionDetails | |||
| // databaseName is specified by the client application | |||
| databaseName string | |||
| options map[string]string | |||
There was a problem hiding this comment.
I believe CodeClimate is complaining about this... go fmt will align the m in map with the s in string on the line above?
doodlesbykumbi
force-pushed
the
pg-pass-client-options
branch
from
a51a8b6 to
5b12ac6
Compare
pg connector sends all client options in startup message. options specified in secretless config take precendence over those sent by the client
doodlesbykumbi
force-pushed
the
pg-pass-client-options
branch
from
624943b to
dd72b31
Compare
|
Code Climate has analyzed commit dd72b31 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 40.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.7% (0.0% change). View more on Code Climate. |
jtuttle
approved these changes
Jan 24, 2022
|
Internal issue: ONYX-14961. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg connector sends all client options in startup message. options specified in secretless config take precendence over those sent by the client
Desired Outcome
Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: insert issue ID
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security