Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang to 1.17 #1441

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Update golang to 1.17 #1441

merged 2 commits into from
Dec 16, 2021

Conversation

szh
Copy link
Contributor

@szh szh commented Dec 13, 2021

Use the latest major version of Go. Also fix ssh tests by replacing RSA test cert with ECDSA

Connected Issue/Story

CyberArk internal issue link: ONYX-14555

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Dec 13, 2021
@szh szh marked this pull request as ready for review December 14, 2021 13:53
@szh szh requested a review from a team as a code owner December 14, 2021 13:53
@szh szh force-pushed the golang-117 branch 3 times, most recently from 42cd849 to 985d02d Compare December 16, 2021 15:48
@szh szh force-pushed the golang-117 branch 4 times, most recently from f82fded to 3b01a83 Compare December 16, 2021 19:00
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szh I think we still need to add HostKeyAlgorithms=ssh-rsa to the ssh test service command. Without it we will have occasional failures like this:

/ # ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -p 2222 secretless ls -la
Unable to negotiate with 172.28.0.4 port 2222: no matching host key type found. Their offer: ssh-rsa

I'm not sure why these are occasional and not all the time. But when we add the HostKeyAlgorithms option it works every time. I know that the occasional failures are resolved by this because the Secretless SSH server uses an ssh-rsa key (and so the client needs to enable that).

@codeclimate
Copy link

codeclimate bot commented Dec 16, 2021

Code Climate has analyzed commit bb81fac and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.8% (0.0% change).

View more on Code Climate.

@szh szh requested a review from doodlesbykumbi December 16, 2021 21:06
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this

@szh szh merged commit 8b93cfb into main Dec 16, 2021
@szh szh deleted the golang-117 branch December 16, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants