Update slosilo to resolve thread-safety bug #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahlee
force-pushed
the
update-slosilo
branch
from
e9c760e to
35fd1b7
Compare
It's not clear what the origin of this is. However, the Sequel gem docs clearly document that if a record doesn't exist, this will return `nil` rather than raise an exception. Original error from logs: ``` NameError (uninitialized constant FindResource::NotFound): app/controllers/concerns/find_resource.rb:23:in `rescue in resource_exists?' app/controllers/concerns/find_resource.rb:20:in `resource_exists?' app/controllers/secrets_controller.rb:119:in `error_info' app/controllers/secrets_controller.rb:23:in `ensure in create' app/controllers/secrets_controller.rb:30:in `create' app/controllers/application_controller.rb:83:in `run_with_transaction' lib/rack/remove_request_parameters.rb:26:in `call' lib/rack/default_content_type.rb:78:in `call' ```
For more detail, see: cyberark/slosilo#31
micahlee
force-pushed
the
update-slosilo
branch
from
35fd1b7 to
bad6f8e
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -18,6 +18,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| detects that either the directory or file do not exist. | |||
| [cyberark/conjur#2715](https://github.com/cyberark/conjur/pull/2715) | |||
|
|
|||
| ### Fixed | |||
| - Fixed a thread-safety bug in secret retrieval when multiple threads attempt | |||
There was a problem hiding this comment.
Lists should be surrounded by blank lines
|
Code Climate has analyzed commit bad6f8e and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (-1.5% change). View more on Code Climate. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
The desired outcome of this PR is to resolve a thread-safety defect with decrypting secret values fixed upstream in cyberark/slosilo#31.
Implemented Changes
This PR updates Slosilo to version 3.0.1 to include the defect fix. It also includes a second commit to fix an uninitialized constant error I also observed while working on this change.
Connected Issue/Story
CyberArk internal issue ID: CNJR-479
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security