Add 'default' account when no name is provided #2388
Conversation
szh
force-pushed
the
2082-default-account
branch
2 times, most recently
from
dcb8463 to
6feaa66
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
szh
force-pushed
the
2082-default-account
branch
3 times, most recently
from
7d60a37 to
e4486b9
Compare
Resolves #2082. Chose not to use `default_value` in `conjur-cli.rb` because the name can be provided by either a flag or argument, and having a default value set by GLI would make it difficult to ascertain which to use.
szh
force-pushed
the
2082-default-account
branch
from
e4486b9 to
18eb0b6
Compare
| @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - Create default account when no account is specified in `conjurctl account create`. | |||
There was a problem hiding this comment.
Lists should be surrounded by blank lines
|
Code Climate has analyzed commit 18eb0b6 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.8% (0.0% change). View more on Code Climate. |
|
@szh or @john-odonnell: Do you know if this change affects Enterprise at all? Does it use this |
|
@alexkalish, fly-by comment... the appliance does use the same underlying rake task that |
|
Thanks @micahlee. So, TL;DR: default is implemented in |
What does this PR do?
conjurctl account createwithout a name argument will create an account with the name "default".What ticket does this PR close?
Resolves #2082
ONYX-13320
Checklists
Change log
Test coverage
Documentation
API Changes