Add E2E workflow github action #348
Conversation
| - main | ||
|
|
||
| # Or when PR operations are done | ||
| pull_request: |
There was a problem hiding this comment.
do we want to add branches: [ master ] so it runs only on PRs to master?
There was a problem hiding this comment.
master branch will soon be renamed to main so I think this is fine as is
There was a problem hiding this comment.
then the same question with main :)
in main.yml we have this guard so PRs to other branches do not run. i think that we should be aligned between GH actions, unless we have a good reason not to be. I'm ok with not having this guard but let's be consistent across actions so let's remove it from there.
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
so will this happen when the PR is merged to main?
|
@NaomiHaser i noticed that this file has a very clear name that says what it does (which is great!). Do you think we should rename |
NaomiHaser
force-pushed
the
test-workflow-githubactions
branch
from
b2b5e90
to
1c46512
Compare
Update action name and path Edit lines and comments Git rules fix
NaomiHaser
force-pushed
the
test-workflow-githubactions
branch
from
1c46512
to
5b1f249
Compare
|
@NaomiHaser thanks for making the alignments! |
* Add E2E workflow github action Update action name and path Edit lines and comments Git rules fix * Change file names and fix PR types * Remove branch master
* Add E2E workflow github action Update action name and path Edit lines and comments Git rules fix * Change file names and fix PR types * Remove branch master
What does this PR do?
A GitHub action(CI flow) in order to validate the E2E workflows.
What ticket does this PR close?
Resolves #340
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, orManual tests
If you are preparing for a release, have you run the following manual tests to verify existing functionality continues to function as expected?