Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JWT Authentication Strategy #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DarioCalovic
Copy link

Desired Outcome

This PR aims to implement the JWTAuthenticationStrategy in the Conjur API to support JWT-based authentication.

Implemented Changes

  • Added the JWTAuthenticationStrategy class to the conjur_api.providers module.
  • Updated imports and added unit tests to ensure proper functionality and error handling for missing parameters.
  • Reviewers should verify the new strategy and run the automated tests.

Connected Issue/Story

Resolves none, self initiated

CyberArk internal issue ID: none

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@DarioCalovic DarioCalovic changed the title AddJWT Authentication Strategy Add JWT Authentication Strategy Oct 10, 2024
@hertus
Copy link

hertus commented Oct 10, 2024

This should be implemented by default. Thanks for the work @DarioCalovic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants