Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support oidc v2 #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

support oidc v2 #43

wants to merge 2 commits into from

Conversation

Nirupma-Verma
Copy link

@Nirupma-Verma Nirupma-Verma commented Aug 3, 2023

Desired Outcome

  • Support added for OIDC authenticator for Conjur CLI and UI
  • Readme updated

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • Support added for OIDC authenticator for Conjur CLI and UI
  • Readme updated

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-requested a review August 3, 2023 13:06
conjur_api/models/general/credentials_data.py Outdated Show resolved Hide resolved
conjur_api/providers/oidc_authentication_strategy.py Outdated Show resolved Hide resolved
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Needs some CodeClimate fixes, a Changelog entry, and tests.

@Nirupma-Verma Nirupma-Verma marked this pull request as ready for review August 9, 2023 14:01
@Nirupma-Verma Nirupma-Verma requested a review from a team as a code owner August 9, 2023 14:01
@Nirupma-Verma Nirupma-Verma requested a review from szh August 9, 2023 14:03
@szh
Copy link
Contributor

szh commented Aug 14, 2023

I'm reviewing this week, but please also look at the CodeClimate issues.

Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions for minor fixes. Can we add an integration test to verify this works with an actual Conjur instance?

tests/https/test_unit_client.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@szh szh requested a review from andytinkham August 16, 2023 16:26
Copy link

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we started discussing in the security review today and then I discussed further with @szh, I have concerns about how this fits in the concept of an API. It is not signed off pending further discussions I've asked @itsbrugu to set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants