Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onyx 26897 excluded token save part , Pls note -" It is not to review " #180

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Pooja-Gangwar
Copy link
Contributor

@Pooja-Gangwar Pooja-Gangwar commented Nov 18, 2022

Desired Outcome

The ansible-lookup-plugin does not support retries

Implemented Changes

Code fix is around supporting re-tries with authentication.
Create a mock test which can return 401 on first call and returns a token on subsequent call to prove re-try logic.

Connected Issue/Story

Jira ticket - ONYX-26897
Bug - https://cyberark.lightning.force.com/lightning/r/Case/5002J00001Y4ffFQAR/view

CyberArk internal issue link: insert issue ID

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • [ x These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@Pooja-Gangwar Pooja-Gangwar requested a review from a team as a code owner November 18, 2022 09:14
@Pooja-Gangwar Pooja-Gangwar changed the title Onyx 26897 excluded token save part Onyx 26897 excluded token save part - Not to review Jan 12, 2023
@Pooja-Gangwar Pooja-Gangwar changed the title Onyx 26897 excluded token save part - Not to review Onyx 26897 excluded token save part Note -" Not to review " Jan 12, 2023
@Pooja-Gangwar Pooja-Gangwar changed the title Onyx 26897 excluded token save part Note -" Not to review " Onyx 26897 excluded token save part , Pls note -" It is not to review " Jan 12, 2023
@szh
Copy link
Contributor

szh commented Jan 20, 2023

I'm going to mark this as a draft since it has Pls note -" It is not to review " in the title.

@szh szh marked this pull request as draft January 20, 2023 18:41
@Pooja-Gangwar
Copy link
Contributor Author

Pooja-Gangwar commented Jan 23, 2023

I'm going to mark this as a draft since it has Pls note -" It is not to review " in the title.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants