-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add randomizer function #9
Comments
Suggestion: cutefetch <animal> <eyes> (It doesn't make sense to have a --flag for this if you cant print two animals at once) And accepting arrays as input: cutefetch (bunny,kitty,doggy) (0, 1, 5, 12) And if an array is passed as an input, have the program choose a random value in it Of course, this could still be used without using the random feature like this: cutefetch kitty2 12 |
That makes a lot of sense. Thanks for the suggestions, @Kalitsune. I think changing the flags to args should be another issue since this issue is just about the randomizer, so I'll make a separate issue on that sometime soon. Also, we should probably still have a "randomize from all" flag or argument, or maybe if |
Sure. But if we're planning on changing the args its probably better not to start implementing the random yet to avoid having to reimplement it once the change is done And yes, using "random" as an arg for randomize all makes a lot of sense we should do that! |
Alright. In that case, you can hold off making the randomizer for now in case you were planning to work on it. I'll make a PR with the new argument parsing system and let you know when it's ready. Thanks for your help and insight on these issues. Enjoy your day(s) 😊 |
Thanks! You too! Good working on it!
…On Thu, Nov 16, 2023, 6:07 PM Sheikh ***@***.***> wrote:
Alright. In that case, you can hold off making the randomizer for now in
case you were planning to work on it.
I'll make a PR with the new argument parsing system and let you know when
it's ready.
Thanks for your help and insight on these issues. Enjoy your day(s) 😊
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARVE2BNIXJCD4E3ZZPFFJT3YEZB3JAVCNFSM6AAAAAA7OFGXL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJUHA3DSMJTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
We want a function in the script that uses
shuf
to randomize the animals and eyes. Currently we only have a note under the Extras section in the readme.Code suggested by @Kalitsune in #8 (comment):
This radomizes the eyes but not the animal. Ideally, we would also randomize the animal. Optionally, we can make it a flag with args, like
-r eyes
and-r animal
, with the default-r
and-r all
having both effects.Changes Requested
randomfetch
orrandfetch
(either is fine but I prefer
randomfetch
since it's more explicit and clear)Acceptance Criteria
-r animal
and--random animal
flags-r eyes
and--random eyes
flags-r
,-r all
,--random
, and--random all
flagsBlockers
The text was updated successfully, but these errors were encountered: