feat(CSP): allow nonce #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 107 109 +2
=====================================
+ Hits 107 109 +2
Continue to review full report at Codecov.
|
arahansen
pushed a commit
to gymnastjs/gymnast
that referenced
this pull request
Dec 15, 2017
Uses a fork of cxs that sets a nonce attribute to the injected style tag if it is globally available. Related cxs PR to merge this functionality into the base lib: cxs-css/cxs#97
arahansen
pushed a commit
to gymnastjs/gymnast
that referenced
this pull request
Dec 15, 2017
Uses a fork of cxs that sets a nonce attribute to the injected style tag if it is globally available. Related cxs PR to merge this functionality into the base lib: cxs-css/cxs#97
arahansen
added a commit
to gymnastjs/gymnast
that referenced
this pull request
Dec 15, 2017
Uses a fork of cxs that sets a nonce attribute to the injected style tag if it is globally available. Related cxs PR to merge this functionality into the base lib: cxs-css/cxs#97
lucasrainett
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding functionality for a nonce attribute to be applied to the injected style tag. This allows stricter CSP security settings to be applied server side, while still allowing for style injection.
This follows a convention set by webpack as seen here (it's essentially undocumented functionality).
And follows a similar setup to how styled components implements nonce attributes.
I tried to keep the bundle size under 1KB, but opted to bump up the threshold in favor of retaining readability of the file. If keeping it to 1KB is important, I can look for other savings? or maybe start uglifying this file to be a more representative format of what most consumers will ingest this lib as.