Run security-dashboards-plugin CI while security-dashboards-plugin is split into 2 separate plugins #7

cwperks · 2024-05-22T19:12:49Z

Companion PR: https://github.com/cwperks/OpenSearch-Dashboards/pull/1/files

In this PR, the security-dashboards-plugin is installed twice for cypress testing.

Session Management Only Mode - In the first instance, the security admin pages are removed and security-dashboards-plugin is in session management mode only. Session management mode is a mode that has log in and log out functionality as well as the ability to switch tenants, view user info and change the logged in user's password.
Security Admin Pages - In the second instance, the security dashboards plugin operates as a shell and only adds the Security pages to OSD. This plugin does not provide the session management functionality.

…ng to be able to disable security admin pages Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>

This reverts commit 018cc7f.

Signed-off-by: Craig Perkins <[email protected]>

RyanL1997

Hi @cwperks, thanks for putting this together. This is indeed a very interesting PR to review. I can see that this experimental change is designed to support MDS. To help bridge my knowledge gap with the new security frontend experience, I've left some conceptual questions in this round of review.

RyanL1997 · 2024-05-24T08:29:24Z

.github/actions/setup-opensearch-dashboards/action.yml

+
+    - uses: actions/checkout@v2
+      with:
+        path: ./OpenSearch-Dashboards/plugins/security-admin-dashboards-plugin


Is this the second installation for Security Admin Pages?

RyanL1997 · 2024-05-24T08:30:46Z

.github/actions/setup-opensearch-dashboards/action.yml

+
+    - uses: actions/checkout@v2
+      with:
+        path: ${{ steps.determine-plugin-directory.outputs.plugin-directory }}


This seems to be the first installation for Session Management Only Mode, is that correct?

RyanL1997 · 2024-05-24T08:35:19Z

.github/actions/setup-opensearch-dashboards/action.yml

+      working-directory: OpenSearch-Dashboards
+      shell: bash
+
+    - name: Create opensearch_dashboards.json for security admin dashboards plugin


I suggest we add a working-directory for this at ./OpenSearch-Dashboards/plugins/security-admin-dashboards-plugin

RyanL1997 · 2024-05-24T08:41:19Z

.github/actions/setup-opensearch-dashboards/action.yml

+    - name: Add to opensearch_dashboards.yml config file
+      run: |
+        echo 'opensearch_security.configuration.admin_pages_enabled: false' >> ./OpenSearch-Dashboards/config/opensearch_dashboards.yml
+        echo 'opensearch_security_admin.configuration.session_management_enabled: false' >> ./OpenSearch-Dashboards/config/opensearch_dashboards.yml


For my knowledge, I do have some conceptual questions about these flags:

what are these flags for? (I guess it is for disable/enable the 2 security dashboards we installed, but why we disabled both of them here?)

Are they enabled by default?

Notice that the prefixes are different opensearch_security vs opensearch_security_admin.

For one of the plugin installations it disables the Admin pages and only manages the session, including login/logout, changing tenant and viewing user info. For the other plugin, it disables session management. In that mode, the plugin acts like any other dashboard plugin where it displays pages for the user to interact with security. It takes for granted that another plugin manages the session.

Signed-off-by: Craig Perkins <[email protected]>

cwperks added 28 commits May 17, 2024 13:28

Introduce opensearch_security.configuration.admin_pages_enabled setti…

918faa5

…ng to be able to disable security admin pages Signed-off-by: Craig Perkins <[email protected]>

Fix typo

27779f9

Signed-off-by: Craig Perkins <[email protected]>

Define common routes

8c1d1e5

Signed-off-by: Craig Perkins <[email protected]>

WIP on admin screen only

36b0098

Signed-off-by: Craig Perkins <[email protected]>

Only register custom error page if pages are enabled

d66fd63

Signed-off-by: Craig Perkins <[email protected]>

Merge branch 'disable-security-pages' into admin-screens-only

da3dd2e

Organize sections in public/plugin.ts

4858db3

Signed-off-by: Craig Perkins <[email protected]>

Remove comment

9ffa45b

Signed-off-by: Craig Perkins <[email protected]>

Merge branch 'disable-security-pages' into admin-screens-only

c653144

Update server/plugin.ts

90f4fc6

Signed-off-by: Craig Perkins <[email protected]>

Update datasource

dbb5318

Signed-off-by: Craig Perkins <[email protected]>

Merge branch 'disable-security-pages' into admin-screens-only

2a93bb0

Remove defineCommonRoutes

4ec526d

Signed-off-by: Craig Perkins <[email protected]>

Fix top nav bar

6e56a42

Signed-off-by: Craig Perkins <[email protected]>

Create common plugin

6ac1fea

Signed-off-by: Craig Perkins <[email protected]>

Pass appropriate handler context

80b58c7

Signed-off-by: Craig Perkins <[email protected]>

Move list

1a2c0dd

Signed-off-by: Craig Perkins <[email protected]>

defineCommonRoutes

1f54c72

Signed-off-by: Craig Perkins <[email protected]>

Surround with try catch

6426257

Signed-off-by: Craig Perkins <[email protected]>

Only register if not already registered

1df7862

Signed-off-by: Craig Perkins <[email protected]>

Revert route handler context change

80c1c38

Signed-off-by: Craig Perkins <[email protected]>

Add defineRoutes backs

f777798

Signed-off-by: Craig Perkins <[email protected]>

Move up logic for defining routes

fd776f3

Signed-off-by: Craig Perkins <[email protected]>

Add all routes

70367e8

Signed-off-by: Craig Perkins <[email protected]>

Revert changes

72b6990

Signed-off-by: Craig Perkins <[email protected]>

Revert changes

002b3d3

Signed-off-by: Craig Perkins <[email protected]>

Merge branch 'disable-security-pages' into admin-screens-only

aefb24a

Run with multiple security-dashboards-plugin

f2c7455

Signed-off-by: Craig Perkins <[email protected]>

cwperks requested review from derek-ho and RyanL1997 as code owners May 22, 2024 19:12

cwperks added 17 commits May 22, 2024 15:37

Use local action

7b334f7

Signed-off-by: Craig Perkins <[email protected]>

Comment out section

d39b947

Signed-off-by: Craig Perkins <[email protected]>

Fix indentation

e7a7801

Signed-off-by: Craig Perkins <[email protected]>

Add shell

7144beb

Signed-off-by: Craig Perkins <[email protected]>

rewrite package.json

e92eb03

Signed-off-by: Craig Perkins <[email protected]>

Change package.json before bootstrap

7498fad

Signed-off-by: Craig Perkins <[email protected]>

minor change

0a0c343

Signed-off-by: Craig Perkins <[email protected]>

Add debug step

1400f56

Signed-off-by: Craig Perkins <[email protected]>

Move opensearch_dashboards.json logic

439f303

Signed-off-by: Craig Perkins <[email protected]>

Update URL

9d4639e

Signed-off-by: Craig Perkins <[email protected]>

Only run linux

e3cb5d4

Signed-off-by: Craig Perkins <[email protected]>

Test change

018cc7f

Signed-off-by: Craig Perkins <[email protected]>

Revert "Test change"

0868d19

This reverts commit 018cc7f.

Update FTR branch

65a1c1c

Signed-off-by: Craig Perkins <[email protected]>

Only run on push

2767f69

Signed-off-by: Craig Perkins <[email protected]>

Remove duplication

c4a9a84

Signed-off-by: Craig Perkins <[email protected]>

Minor change

cd69d85

Signed-off-by: Craig Perkins <[email protected]>

RyanL1997 reviewed May 24, 2024

View reviewed changes

cwperks added 2 commits May 24, 2024 09:27

Remove agg view test

e491ea7

Signed-off-by: Craig Perkins <[email protected]>

Use correct prefix

8655bec

Signed-off-by: Craig Perkins <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run security-dashboards-plugin CI while security-dashboards-plugin is split into 2 separate plugins #7

Run security-dashboards-plugin CI while security-dashboards-plugin is split into 2 separate plugins #7

cwperks commented May 22, 2024

RyanL1997 left a comment

RyanL1997 May 24, 2024 •

edited

Loading

RyanL1997 May 24, 2024

RyanL1997 May 24, 2024

RyanL1997 May 24, 2024

cwperks May 24, 2024

Run security-dashboards-plugin CI while security-dashboards-plugin is split into 2 separate plugins #7

Are you sure you want to change the base?

Run security-dashboards-plugin CI while security-dashboards-plugin is split into 2 separate plugins #7

Conversation

cwperks commented May 22, 2024

RyanL1997 left a comment

Choose a reason for hiding this comment

RyanL1997 May 24, 2024 • edited Loading

Choose a reason for hiding this comment

RyanL1997 May 24, 2024

Choose a reason for hiding this comment

RyanL1997 May 24, 2024

Choose a reason for hiding this comment

RyanL1997 May 24, 2024

Choose a reason for hiding this comment

cwperks May 24, 2024

Choose a reason for hiding this comment

RyanL1997 May 24, 2024 •

edited

Loading