Basketball League Transactions #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
==========================================
- Coverage 83.98% 83.18% -0.80%
==========================================
Files 60 61 +1
Lines 2254 2290 +36
==========================================
+ Hits 1893 1905 +12
- Misses 361 385 +24 ☔ View full report in Codecov by Sentry. |
cwendt94
reviewed
Nov 1, 2024
| @@ -0,0 +1,7 @@ | |||
| class TransactionItem(object): | |||
There was a problem hiding this comment.
this might be better defined in the same file as transactions
espn_api/basketball/league.py
Outdated
| 'scoringPeriodId': scoring_period, | ||
| } | ||
|
|
||
| filters = {"transactions":{"filterType":{"value":["FREEAGENT","WAIVER","WAIVER_ERROR"]}}} |
There was a problem hiding this comment.
I think having these filter types as default is good and then allow it to be passed in to the function as well in case you only want to look for one or different ones.
|
Thanks for the feedback @cwendt94! Updated accordingly. |
cwendt94
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New method
League.transactions()uses themTransactions2view to fetch more detailed transaction data than is available throughrecent_activity.I'm only fetching free agent and waiver transactions right now because that's the only data I have available to test with in my league, however trades and roster moves are also available. In my testing I got a surprisingly helpful error message that enumerated all available transaction types:
DRAFT, TRADE_ACCEPT, WAIVER, TRADE_VETO, FUTURE_ROSTER, ROSTER, RETRO_ROSTER, TRADE_PROPOSAL, TRADE_UPHOLD, FREEAGENT, TRADE_DECLINE, WAIVER_ERROR, TRADE_ERROR