fixed pybind11 error #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's really weird. The bug you reported in #15 isn't 'Module not found', but it's that pybind11 can't find Eigen. We saw this bug earlier because eigen wasn't included in the source distribution, but I've fixed that & installation from pip just works for me now. The change in this PR shouldn't fix not being able to find Eigen headers. |
|
It’s because we include pybind11/eigen first. I suspect that if we put
pybind11/pybind11 first, well have the same issue.
…On Sun, Oct 20, 2019 at 3:04 PM Akshay Agrawal ***@***.***> wrote:
That's really weird. The bug you reported in #15
<#15> isn't 'Module not found',
but it's that pybind11 can't find Eigen. We saw this bug earlier because
eigen wasn't included in the source distribution, but I've fixed that &
installation from pip just works for me now. The change in this PR
shouldn't fix not being able to find Eigen headers.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20?email_source=notifications&email_token=AB7LUGJ5YY4GBZQJT4YV7XTQPTIYVA5CNFSM4JCWINOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYVE2Q#issuecomment-544297578>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7LUGKMWFIKLEPU47BGXDTQPTIYVANCNFSM4JCWINOA>
.
|
|
Are you installing from the test repo or from pypi? Can you try installing the latest version (1.0.6) from pypi in a fresh environment and posting the entire error message? |
|
Okay, never mind my previous post, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a la pybind/python_example#32