-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command set versionning (fix #34) #40
Conversation
The removed test checked for absence of behavior, which is not a good test since it will not invalidate if the behaviour is not present due to something else.
Why don't you use the |
Well it would change the CRC, so you would have to repair the tests either way. Although the best is probably to compute the CRC automatically. |
We should probably add compatibility tests between python and C implementations. |
I was thinking about it too, but I don't know if it is worth it. I would do it by making a C to Python binding to the target code and then write all compatibility tests in python. |
opened an issue #41 to discuss this topic. |
It should not be a problem as |
I think this can merge. |
Command set versionning (fix #34)
first pull request of the year \o/
This implements command set versionning. I am not entierly sure of my implementation details, especially for the tests, so peer review welcomed.