Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytlbd and TP-LSD from third-party. Move hawp to separate installation #100

Merged
merged 6 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,6 @@
[submodule "third-party/pytlsd"]
path = third-party/pytlsd
url = https://github.com/iago-suarez/pytlsd.git
[submodule "third-party/pytlbd"]
path = third-party/pytlbd
url = https://github.com/iago-suarez/pytlbd.git
[submodule "third-party/hawp"]
path = third-party/hawp
url = https://github.com/cherubicXN/hawp.git
ignore = dirty
[submodule "third-party/TP-LSD"]
path = third-party/TP-LSD
url = https://github.com/rpautrat/TP-LSD.git
[submodule "third-party/DeepLSD"]
path = third-party/DeepLSD
url = https://github.com/cvg/DeepLSD.git
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ If you wish to use the methods with **separate installation needed** you need to
**The following line detectors are currently supported:**
- [LSD](https://github.com/iago-suarez/pytlsd)
- [SOLD2](https://github.com/cvg/SOLD2)
- [HAWPv3](https://github.com/cherubicXN/hawp)
- [HAWP](https://github.com/cherubicXN/hawp) (separate installation needed [[Guide](misc/install/hawpv3.md)])
- [TP-LSD](https://github.com/Siyuada7/TP-LSD) (separate installation needed [[Guide](misc/install/tp_lsd.md)])
- [DeepLSD](https://github.com/cvg/DeepLSD)

Expand Down
8 changes: 8 additions & 0 deletions misc/install/hawpv3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
## HAWP installation

```bash
git clone --recursive https://github.com/cherubicXN/hawp.git ./third-party/hawp
python -m pip install -e ./third-party/hawp
```

Since HAWP (original link: [https://github.com/cherubicXN/hawp](https://github.com/cherubicXN/hawp)) is still under active development and we do not want to block the user from using the newest version, it is now listed as a separate dependency.
1 change: 1 addition & 0 deletions misc/install/lbd.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ sudo apt-get install libopencv-dev libopencv-contrib-dev libarpack++2-dev libarp
```
Then install the pytlbd Python package from [Iago Suárez](https://github.com/iago-suarez)
```bash
git clone --recursive https://github.com/iago-suarez/pytlbd.git ./third-party/pytlbd
python -m pip install -e ./third-party/pytlbd
```
The LBD is listed as a dependency with separate installation to avoid the OpenCV dependency. When using the LBD matcher inside LIMAP, please use the parallelization with ``--line2d.matcher.n_jobs 8`` (8 cores, you can use even more CPU cores if applicable).
Expand Down
1 change: 1 addition & 0 deletions misc/install/tp_lsd.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## TP-LSD installation

```bash
git clone --recursive https://github.com/rpautrat/TP-LSD.git ./third-party/TP-LSD
python -m pip install -e ./third-party/TP-LSD/tp_lsd/modeling/DCNv2
python -m pip install -e ./third-party/TP-LSD
```
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ ruff==0.6.7
clang-format==19.1.0

./third-party/pytlsd
./third-party/hawp
-e ./third-party/Hierarchical-Localization
-e ./third-party/DeepLSD
-e ./third-party/GlueStick
1 change: 0 additions & 1 deletion third-party/TP-LSD
Submodule TP-LSD deleted from 555805
1 change: 0 additions & 1 deletion third-party/hawp
Submodule hawp deleted from 45bd43
1 change: 0 additions & 1 deletion third-party/pytlbd
Submodule pytlbd deleted from b0c8cf