Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the force registration of tentacles #153

Merged
merged 3 commits into from
Jan 17, 2020

Conversation

NootN00t
Copy link
Contributor

Description

Support flags for commands, in the immediate case here, force.

Enables logic where a machine may have been torn down to be rebuilt and an orphaned reference within Octo exists that is no longer valid

Reformatted a PS command to make it easier to read.

Issues Resolved

N/A

Contribution Check List

  • All tests pass.
  • New functionality includes testing.
  • New functionality has been documented in the README.

@NootN00t NootN00t force-pushed the support_the_force branch 3 times, most recently from 6784762 to 1c34357 Compare December 11, 2019 12:15
@brentm5
Copy link
Member

brentm5 commented Jan 6, 2020

Can you downmerge master into this branch?

@codecov-io
Copy link

Codecov Report

Merging #153 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #153   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          95     97    +2     
=====================================
+ Hits           95     97    +2
Impacted Files Coverage Δ
libraries/shared.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b0468...6d78033. Read the comment docs.

@NootN00t
Copy link
Contributor Author

NootN00t commented Jan 8, 2020

No probs, all good?

@brentm5 brentm5 changed the title Support the force Support the force registration of tentacles Jan 17, 2020
@brentm5 brentm5 merged commit abb6c87 into cvent:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants