Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to the authentication with Amazon Cognito #8877

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Dec 25, 2024

Motivation and context

I haven't noticed that #8557 broke the link to the section about authentication with Amazon Cognito service.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features
    • Enhanced social authentication configuration documentation for Enterprise clients.
  • Bug Fixes
    • Improved clarity and structure of instructions for enabling authentication with Google, GitHub, and Amazon Cognito.
  • Documentation
    • Reformatted authentication options for better navigation and consistency.
    • Added details for Amazon Cognito configuration, including optional steps and specific settings.

@Marishka17 Marishka17 added the documentation Documentation should be updated label Dec 25, 2024
Copy link
Contributor

coderabbitai bot commented Dec 25, 2024

Walkthrough

The documentation for social authentication configuration in the enterprise documentation has been updated to improve clarity, structure, and readability. The changes include adding an Enterprise client note, reformatting authentication options, streamlining language, and providing more consistent and detailed instructions for configuring Google, GitHub, and Amazon Cognito authentication methods.

Changes

File Change Summary
site/content/en/docs/enterprise/social-accounts-configuration.md - Added Enterprise client note
- Converted bullet list to numbered list with hyperlinks
- Standardized section headers
- Reorganized and clarified authentication instructions
- Updated document title and description

Poem

🐰 Hop into social auth with glee,
Configuration now clear as can be!
Numbered steps, links so bright,
Enterprise features shining light
Authentication's rabbit delight! 🔐


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Marishka17
Copy link
Contributor Author

@SpecLad, 👀

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (2)
site/content/en/docs/enterprise/social-accounts-configuration.md (2)

Line range hint 47-48: Fix typo in Google callback URL.

There's a typo in the callback URL example:

-https://localhost:8080/api/auth/social/goolge/login/callback/
+https://localhost:8080/api/auth/social/google/login/callback/

Line range hint 58-58: Fix missing quotes in environment variable examples.

The AUTH_CONFIG_PATH environment variable is missing a closing quote in multiple places throughout the document.

-AUTH_CONFIG_PATH="<path_to_auth_config>
+AUTH_CONFIG_PATH="<path_to_auth_config>"

Also applies to: 89-89, 156-160

🧹 Nitpick comments (1)
site/content/en/docs/enterprise/social-accounts-configuration.md (1)

Line range hint 1-180: Consider adding screenshots for Google and GitHub configurations.

The Amazon Cognito section includes helpful screenshots that make the configuration process clearer. Consider adding similar screenshots for the Google and GitHub configuration sections to maintain consistency across the document.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1d0a6c and ec1a35b.

📒 Files selected for processing (1)
  • site/content/en/docs/enterprise/social-accounts-configuration.md (3 hunks)
🔇 Additional comments (2)
site/content/en/docs/enterprise/social-accounts-configuration.md (2)

22-24: Navigation links are now correctly formatted.

The links to all authentication sections, including the previously broken Amazon Cognito link, are now properly formatted and functional.


Line range hint 103-115: Well-structured documentation with clear sections.

The document structure is clear and logical, with a good breakdown of steps for Amazon Cognito configuration. The use of subsections makes it easy to follow the setup process.

@Marishka17 Marishka17 merged commit 9a25291 into develop Dec 27, 2024
16 checks passed
@Marishka17 Marishka17 deleted the mk/fix-doc-link branch December 27, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation should be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants