Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ModelProvider interface #8860

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Dec 23, 2024

Motivation and context

It was only used in the Enterprise version, so I moved it there.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • Bug Fixes
    • Removed the ModelProvider interface, streamlining the management of model providers.
    • Removed the ModelProvider export, updating the module's interface.

It was only used in the Enterprise version, so I moved it there.
@SpecLad SpecLad requested a review from klakhov December 23, 2024 15:35
@SpecLad SpecLad requested a review from bsekachev as a code owner December 23, 2024 15:35
Copy link
Contributor

coderabbitai bot commented Dec 23, 2024

Walkthrough

The changes involve the removal of the ModelProvider interface from two files: cvat-core/src/lambda-manager.ts and cvat-ui/src/cvat-core-wrapper.ts. This modification suggests a refactoring of how model providers are defined and exported in the codebase. The interface, which previously contained properties like name, icon, and attributes, has been completely removed from both the core and UI wrapper modules.

Changes

File Change Summary
cvat-core/src/lambda-manager.ts Removed ModelProvider interface
cvat-ui/src/cvat-core-wrapper.ts Removed ModelProvider from exports

Poem

🐰 Farewell, ModelProvider dear,
Your interface has disappeared
No more name, no more icon bright
In code's evolution, out of sight
A rabbit's whisper says goodbye 🔍


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12f886c and f98db2a.

📒 Files selected for processing (2)
  • cvat-core/src/lambda-manager.ts (0 hunks)
  • cvat-ui/src/cvat-core-wrapper.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • cvat-core/src/lambda-manager.ts
  • cvat-ui/src/cvat-core-wrapper.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.88%. Comparing base (12f886c) to head (f98db2a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8860   +/-   ##
========================================
  Coverage    73.88%   73.88%           
========================================
  Files          408      408           
  Lines        44104    44104           
  Branches      3986     3986           
========================================
+ Hits         32586    32587    +1     
+ Misses       11518    11517    -1     
Components Coverage Δ
cvat-ui 78.35% <ø> (+<0.01%) ⬆️
cvat-server 70.08% <ø> (ø)

@SpecLad SpecLad merged commit 2fd48c8 into cvat-ai:develop Dec 24, 2024
35 checks passed
@SpecLad SpecLad deleted the rm-model-provider branch December 24, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants