Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ModelDeleteMixin from TasksRepo base classes #8786

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Dec 6, 2024

Motivation and context

This mixin is for entities, not repositories. Presumably it was added by mistake.

The remove method it adds won't work on a repository, so removing it doesn't break anything.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Enhanced logging for task deletion attempts, providing better feedback on success or failure.
  • Bug Fixes

    • Improved error handling for task removal operations, ensuring clearer messages when tasks are not found or deletions fail.

This mixin is for entities, not repositories. Presumably it was added by
mistake.

The `remove` method it adds won't work on a repository, so removing it
doesn't break anything.
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024

Walkthrough

The changes involve modifications to the TasksRepo class in the tasks.py file, specifically removing the ModelDeleteMixin from its inheritance. This alteration eliminates the class's ability to directly delete tasks. Additionally, the remove_by_ids method has been updated to enhance logging capabilities, providing feedback on deletion attempts, including success and failure messages. These updates streamline the class's functionality while improving error handling related to task management.

Changes

File Path Change Summary
cvat-sdk/cvat_sdk/core/proxies/tasks.py Removed ModelDeleteMixin from TasksRepo class inheritance; updated remove_by_ids method to log deletion attempts and errors.

Poem

In the code where tasks once flew,
A mixin gone, a change so new.
With logs that tell of tasks' demise,
We streamline paths and clear the skies.
Hops of joy for cleaner ways,
In the code, we dance and play! 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ca3d700 and d874211.

📒 Files selected for processing (1)
  • cvat-sdk/cvat_sdk/core/proxies/tasks.py (0 hunks)
💤 Files with no reviewable changes (1)
  • cvat-sdk/cvat_sdk/core/proxies/tasks.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Dec 6, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.92%. Comparing base (ebe3dd6) to head (d874211).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8786   +/-   ##
========================================
  Coverage    73.92%   73.92%           
========================================
  Files          409      409           
  Lines        43944    43950    +6     
  Branches      3985     3985           
========================================
+ Hits         32485    32492    +7     
+ Misses       11459    11458    -1     
Components Coverage Δ
cvat-ui 78.35% <ø> (+<0.01%) ⬆️
cvat-server 70.14% <100.00%> (+<0.01%) ⬆️

@SpecLad SpecLad merged commit caff6ee into cvat-ai:develop Dec 6, 2024
35 checks passed
@SpecLad SpecLad deleted the remove-bad-mixin branch December 6, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants