-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reblacken code after #8360 #8609
Conversation
WalkthroughThe changes involve modifications to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (1)tests/python/shared/fixtures/init.py (1)
The consolidation of file operations into a single Let's verify the Python version requirement is met: ✅ Verification successfulPython 3.9 requirement is met, change is safe to use The codebase explicitly targets Python 3.9 as confirmed in pyproject.toml's black configuration ( 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check Python version in the project
rg -g "setup.py|pyproject.toml|requirements*.txt" "python.*version" -A 5
Length of output: 223 Script: #!/bin/bash
# Let's try different approaches to find Python version requirements
# 1. Look for pyproject.toml with different case
fd -i "pyproject.toml"
# 2. Look for any setup files
fd -i "setup.py"
# 3. Look for requirements files
fd -i "requirements"
# 4. Check for Python version in tox.ini if it exists
fd -i "tox.ini"
# 5. Look for CI configuration files that might specify Python version
fd -i ".python-version"
fd -e yml -e yaml | grep -i "github\|gitlab\|azure"
Length of output: 643 Script: #!/bin/bash
# Let's check the Python version requirements in the found files
cat pyproject.toml tests/python/pyproject.toml tests/python/requirements.txt 2>/dev/null | grep -i "python"
# Also check the GitHub workflow files specifically for Python version
fd -e yml -e yaml -d 1 -p .github/workflows/ | xargs cat 2>/dev/null | grep -A 5 -B 5 "python-version"
Length of output: 209 Script: #!/bin/bash
# Let's check the content of the test file itself for any Python version hints
cat tests/python/shared/fixtures/init.py | grep -B 5 -A 5 "import"
# Also check the main pyproject.toml content fully
cat pyproject.toml
# And check the test's pyproject.toml
cat tests/python/pyproject.toml
Length of output: 1351 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
@Marishka17 FYI. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8609 +/- ##
===========================================
- Coverage 74.20% 74.19% -0.01%
===========================================
Files 403 403
Lines 43375 43375
Branches 3925 3925
===========================================
- Hits 32185 32181 -4
- Misses 11190 11194 +4
|
Motivation and context
Starting with Python 3.9,
with
allows parenthesized context managers, which black will use when needed.How has this been tested?
Checklist
develop
branch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Downloader
class andcreate_compose_files
function.