Stabilize E2E tests #8465
Stabilize E2E tests #8465
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe change updates the method for closing the export completion notification on the requests page. Instead of using a specific method call to close the notification, the new implementation identifies the notification by its text "Export is finished" and then finds the close button through its Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
tests/cypress/e2e/features/requests_page.js (1)
Line range hint
1-380: Overall improvement in test stability, but consider broader enhancementsThe changes to the
closeExportNotificationfunction effectively address the PR objectives by improving the test's ability to handle multiple notifications. This is a positive step towards stabilizing the regression test.To further enhance the overall test suite:
Consider extracting the
closeExportNotificationfunction to a shared utility file, as it might be useful in other tests dealing with export notifications.Implement a more generic notification handling utility that can close notifications based on different texts or types, making it reusable across various test scenarios.
Review other parts of the test suite for similar notification handling patterns and update them for consistency.
Add more comprehensive error logging throughout the test to aid in debugging test failures.
Consider adding a test case that specifically verifies the behavior when multiple notifications are present simultaneously.
These suggestions will help improve the overall maintainability and robustness of the test suite beyond just this specific regression test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8465 +/- ##
===========================================
- Coverage 83.22% 83.20% -0.02%
===========================================
Files 397 397
Lines 41907 41907
Branches 3882 3882
===========================================
- Hits 34876 34870 -6
- Misses 7031 7037 +6
|
|
/check |
|
❌ Some checks failed |
|
Motivation and context
requests page tests:
The is a potential issue in regression test. As we test 2 exports one by one, there can be 2 pop-up notifications about successful operation. But our command cy.closeNotification expects only one. So changed logic a bit in test so it doesnt crush even if there is several notifications
quality_management tests:
sometimes actions button is not clicked
How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit