-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for basic Management
tab on Quality control
page
#8447
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes involve enhancements to the styling of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Cypress
participant ManagementTab
User->>Cypress: Trigger test suite
Cypress->>ManagementTab: Open management tab
ManagementTab->>Cypress: Validate contents and links
Cypress->>ManagementTab: Check frame allocation
ManagementTab->>Cypress: Return frame status
Cypress->>User: Display test results
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Outside diff range and nitpick comments (2)
tests/cypress/e2e/features/ground_truth_jobs.js (1)
Line range hint
338-340
: Incorrect use ofafterEach
leading to premature task deletionUsing
afterEach
to delete the task after each test could cause subsequent tests to fail because the task would no longer exist. If the intention is to delete the task after all tests have completed, useafter
instead ofafterEach
.Apply this diff to correct the hook:
-afterEach(() => { +after(() => { cy.headlessDeleteTask(taskID); });tests/cypress/support/commands.js (1)
174-175
: Consider using empty objects{}
as default parameters instead ofnull
Using empty objects
{}
as default values formultiAttrParams
andadvancedConfigurationParams
can prevent potentialnull
reference errors if these parameters are used without null checks within the function.Apply this diff to improve default parameter handling:
multiAttrParams = {}, advancedConfigurationParams = {},
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- cvat-ui/src/components/quality-control/task-quality/allocation-table.tsx (4 hunks)
- cvat-ui/src/components/quality-control/task-quality/summary.tsx (2 hunks)
- tests/cypress/e2e/features/ground_truth_jobs.js (3 hunks)
- tests/cypress/support/commands.js (2 hunks)
Files skipped from review due to trivial changes (2)
- cvat-ui/src/components/quality-control/task-quality/allocation-table.tsx
- cvat-ui/src/components/quality-control/task-quality/summary.tsx
Additional comments not posted (1)
tests/cypress/e2e/features/ground_truth_jobs.js (1)
91-97
: Good use of helper function for opening the Management tabThe
openManagementTab
function promotes code reuse and improves readability by encapsulating the steps to navigate to the Management tab.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8447 +/- ##
===========================================
+ Coverage 83.10% 83.22% +0.12%
===========================================
Files 397 397
Lines 41907 41907
Branches 3882 3882
===========================================
+ Hits 34825 34876 +51
+ Misses 7082 7031 -51
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
Quality Gate passedIssues Measures |
Motivation and context
This PR adds tests for
management
tab that was introduced in #8329How has this been tested?
Checklist
develop
branch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes