Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable further checking permissions if at least one is False #7803

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Apr 25, 2024

Motivation and context

To avoid extra requests to the database, opa container and code execution on the server

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from SpecLad April 25, 2024 10:11
@bsekachev bsekachev requested a review from Marishka17 as a code owner April 25, 2024 10:11
@nmanovic
Copy link
Contributor

@bsekachev , let's add a line into changelog. The optimization looks good. Need double check. Do you have any numbers to estimate the enhancement?

@bsekachev bsekachev requested a review from nmanovic as a code owner April 25, 2024 13:17
@bsekachev bsekachev merged commit 734e748 into develop Apr 25, 2024
32 checks passed
@cvat-bot cvat-bot bot mentioned this pull request Apr 26, 2024
@bsekachev bsekachev deleted the bs/minor_optimization branch May 6, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants