Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for .rar and some other archives #7729

Merged
merged 13 commits into from
Apr 11, 2024
Merged

Added support for .rar and some other archives #7729

merged 13 commits into from
Apr 11, 2024

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Apr 5, 2024 •
edited
Loading

Motivation and context

This PR allows users to upload .rar archives during task creation.
It fixes several problems:

  1. Outdated mimetype for .rar type which is now x-rar-compressed
  2. Adds usage of patool util for pyunpack package, which previously used only zipfile. Patool can handle different kinds of archives, current supported list(by mimetype) can be found in the supportedArchives
    1. The pipeline for rar archives now is pyunpack -> patool -> unrar

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov added the server label Apr 5, 2024
@klakhov klakhov requested a review from azhavoro April 5, 2024 06:17
@klakhov klakhov requested a review from Marishka17 as a code owner April 5, 2024 06:17
@klakhov klakhov removed the request for review from Marishka17 April 5, 2024 06:17
@klakhov klakhov requested a review from nmanovic as a code owner April 5, 2024 06:20
@klakhov klakhov removed the request for review from nmanovic April 5, 2024 06:21
SpecLad
SpecLad reviewed Apr 5, 2024
View reviewed changes
changelog.d/20240405_091941_klakhov_rar_support.md Outdated Show resolved Hide resolved
cvat/apps/engine/media_extractors.py Outdated Show resolved Hide resolved
cvat/apps/engine/media_extractors.py Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@klakhov klakhov changed the title Added support for .rar archives Added support for .rar and some other archives Apr 9, 2024
SpecLad
SpecLad requested changes Apr 10, 2024
View reviewed changes
cvat/apps/engine/tests/test_rest_api.py Outdated Show resolved Hide resolved
cvat/apps/engine/tests/test_rest_api.py Outdated Show resolved Hide resolved
cvat/apps/engine/tests/test_rest_api.py Outdated Show resolved Hide resolved
cvat/apps/engine/tests/test_rest_api.py Outdated Show resolved Hide resolved
cvat/apps/engine/tests/test_rest_api.py Show resolved Hide resolved
SpecLad
SpecLad reviewed Apr 11, 2024
View reviewed changes
cvat/apps/engine/tests/test_rest_api.py Outdated Show resolved Hide resolved
cvat/apps/engine/tests/test_rest_api.py Outdated Show resolved Hide resolved
cvat/apps/engine/tests/test_rest_api.py Outdated Show resolved Hide resolved
@klakhov klakhov merged commit 3fe396c into develop Apr 11, 2024
32 checks passed
@klakhov klakhov deleted the kl/rar-support branch April 13, 2024 08:01
@cvat-bot cvat-bot bot mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpecLad SpecLad SpecLad approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

Assignees
No one assigned
Labels
server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klakhov @SpecLad @azhavoro