[GSoC2024] Fix import of outside track shapes in Datumaro-based formats

changelog.d/20240403_135916_yeek020407_switch_outside.md

@@ -0,0 +1,4 @@
+### Fixed
+
+- Check the end of outside attribute for tracked format
+  (<https://github.com/opencv/cvat/pull/7669>)

cvat/apps/dataset_manager/bindings.py

@@ -2080,7 +2080,7 @@ def reduce_fn(acc, v):
                         ))
                         continue
 
-                    if keyframe or outside:
+                    if track_id is not None:
                         if track_id not in tracks:
                             tracks[track_id] = {
                                 'label': label_cat.items[ann.label].name,
@@ -2151,6 +2151,26 @@ def reduce_fn(acc, v):
                 raise CvatImportError("Image {}: can't import annotation "
                     "#{} ({}): {}".format(item.id, idx, ann.type.name, e)) from e
 
+    for track in tracks.values():
+        track['shapes'].sort(key=lambda t: t.frame)
+        prev_shape_idx = 0
+        prev_shape = track['shapes'][0]
+        for shape in track['shapes'][1:]:
+            has_skip = instance_data.frame_step < shape.frame - prev_shape.frame
+            if has_skip and not prev_shape.outside:
+                prev_shape = prev_shape._replace(outside=True,
+                        frame=prev_shape.frame + instance_data.frame_step)
+                prev_shape_idx += 1
+                track['shapes'].insert(prev_shape_idx, prev_shape)
+            prev_shape = shape
+            prev_shape_idx += 1
+
+        # if the last shape 'outside' is False, we need to add to stop the tracking
+        if not prev_shape.outside and prev_shape.frame+instance_data.frame_step <= frame_number:
+            prev_shape = prev_shape._replace(outside=True,
+                    frame=prev_shape.frame + instance_data.frame_step)
+            track['shapes'].append(prev_shape)
+
     for track in tracks.values():
         track['elements'] = list(track['elements'].values())
         instance_data.add_track(instance_data.Track(**track))

cvat/apps/dataset_manager/tests/assets/annotations.json

@@ -807,6 +807,52 @@
     ],
     "tracks": []
   },
+  "Datumaro 1.0 outside true": {
+    "version": 0,
+    "tags": [
+      {
+        "frame": 0,
+        "label_id": null,
+        "group": 0,
+        "source": "manual",
+        "attributes": []
+      }
+    ],
+    "shapes": [],
+    "tracks": [
+      {
+        "frame": 0,
+        "label_id": null,
+        "group": 0,
+        "source": "manual",
+        "shapes": [
+          {
+            "type": "rectangle",
+            "occluded": false,
+            "z_order": 0,
+            "points": [5.54, 3.5, 19.64, 11.19],
+            "frame": 0,
+            "keyframe": true,
+            "outside": false,
+            "rotation":0,
+            "attributes": []
+          },
+          {
+            "type": "rectangle",
+            "occluded": false,
+            "z_order": 0,
+            "points": [5.54, 3.5, 19.64, 11.19],
+            "frame": 1,
+            "keyframe": false,
+            "outside": true,
+            "rotation":0,
+            "attributes": []
+          }
+        ],
+        "attributes": []
+      }
+    ]
+  },
   "CVAT for images 1.1 many jobs": {
     "version": 0,
     "tags": [

cvat/apps/dataset_manager/tests/test_rest_api_formats.py

@@ -1045,6 +1045,47 @@ def test_api_v2_tasks_annotations_dump_and_upload_many_jobs_with_datumaro(self):
                     data_from_task_after_upload = self._get_data_from_task(task_id, include_images)
                     compare_datasets(self, data_from_task_before_upload, data_from_task_after_upload)
 
+    def test_api_v2_tasks_annotations_dump_and_upload_with_datumaro_outside_true(self):
+        test_name = self._testMethodName
+        import_format = "Datumaro 1.0"
+        dump_format_name = "Datumaro 1.0 outside true"
+        include_images_params = (False, True)
+
+        for include_images in include_images_params:
+            with self.subTest(import_format):
+
+                # use Datumaro 1.0 annotations that contains outside property with True value
+                images = self._generate_task_images(3)
+                task = self._create_task(tasks["main"], images)
+                self._create_annotations(task, dump_format_name, "default")
+                task_id = task["id"]
+                data_from_task_before_upload = self._get_data_from_task(task_id, include_images_params[0])
+
+                with TestDir() as test_dir:
+                    # download annotations using track_formats
+                    url = self._generate_url_dump_tasks_annotations(task_id)
+                    file_zip_name = osp.join(test_dir, f'{test_name}_{import_format}.zip')
+                    data = {
+                        "format": import_format,
+                        "action": "download",
+                    }
+                    self._download_file(url, data, self.admin, file_zip_name)
+                    self._check_downloaded_file(file_zip_name)
+
+                    # remove annotations
+                    self._remove_annotations(url, self.admin)
+
+                    # upload annotations
+                    upload_format_name = import_format
+                    url = self._generate_url_upload_tasks_annotations(task_id, upload_format_name)
+                    with open(file_zip_name, 'rb') as binary_file:
+                        self._upload_file(url, binary_file, self.admin)
+
+                    # equals annotations
+                    data_from_task_after_upload = self._get_data_from_task(task_id, include_images)
+                    compare_datasets(self, data_from_task_before_upload, data_from_task_after_upload)
+
+
     def test_api_v2_tasks_annotations_dump_and_upload_with_datumaro(self):
         test_name = self._testMethodName
         # get formats