Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scope defining when checking status of project import #7555

Merged

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Mar 5, 2024

Motivation and context

This PR fixes issue CS-670

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
    - [ ] I have updated the documentation accordingly
    - [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17 Marishka17 requested a review from SpecLad March 5, 2024 14:14
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #7555 (80e43a5) into develop (9e605f4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7555      +/-   ##
===========================================
- Coverage    83.45%   83.44%   -0.01%     
===========================================
  Files          373      373              
  Lines        39739    39739              
  Branches      3741     3741              
===========================================
- Hits         33163    33160       -3     
- Misses        6576     6579       +3     
Components Coverage Δ
cvat-ui 79.23% <ø> (-0.02%) ⬇️
cvat-server 87.32% <ø> (ø)

@SpecLad
Copy link
Contributor

SpecLad commented Mar 5, 2024

Please add a changelog entry.

@Marishka17 Marishka17 force-pushed the mk/fix_scope_defining_when_checking_project_permissions branch from d5639aa to 6bca1ac Compare March 6, 2024 12:43
@Marishka17 Marishka17 requested a review from nmanovic as a code owner March 6, 2024 12:43
@@ -0,0 +1,4 @@
### Fixed

- Scope definition when checking project permissions while requesting status of project import
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't tell much to someone not familiar with the internals of our IAM system. Can you explain the effect of this change from the perspective of a user?

@bsekachev bsekachev merged commit e431d28 into develop Mar 15, 2024
34 checks passed
@bsekachev bsekachev deleted the mk/fix_scope_defining_when_checking_project_permissions branch April 15, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants