[GSoC2024] added better error message when video resolution too large #7549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7549 +/- ##
===========================================
- Coverage 83.45% 83.45% -0.01%
===========================================
Files 373 373
Lines 39742 39746 +4
Branches 3741 3741
===========================================
+ Hits 33168 33171 +3
- Misses 6574 6575 +1
|
nmanovic
changed the title
|
Hey @Marishka17 a gentle reminder to review this PR. |
Marishka17
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Hello, @Viditagarwal7479,
Thank you for your contribution! Could you please fix minor comments?
|
Hi @Marishka17, how will this PR get merged after your approval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On uploading video files exceeding the maximum resolution supported by OpenH264, it raises error while trying to decode the video. To handle this more gracefully I have added dimension check based on which it raises an error beforehand with appropriate message.
Motivation and context
Fixes #7425
Checklist
developbranch- [ ] I have created a changelog fragment- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.