Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Ground truth Job list #7490

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Feb 19, 2024

Motivation and context

Test for bug which was fixed in #7441

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov marked this pull request as ready for review February 19, 2024 10:43
@klakhov klakhov requested a review from azhavoro as a code owner February 19, 2024 10:43
@klakhov klakhov removed the request for review from azhavoro February 19, 2024 10:43
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #7490 (404baf9) into develop (7286d65) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7490      +/-   ##
===========================================
- Coverage    83.52%   83.51%   -0.01%     
===========================================
  Files          372      372              
  Lines        39666    39666              
  Branches      3718     3718              
===========================================
- Hits         33131    33129       -2     
- Misses        6535     6537       +2     
Components Coverage Δ
cvat-ui 79.39% <ø> (-0.02%) ⬇️
cvat-server 87.31% <ø> (ø)

tests/cypress/e2e/features/ground_truth_jobs.js Outdated Show resolved Hide resolved
tests/cypress/e2e/features/ground_truth_jobs.js Outdated Show resolved Hide resolved
Comment on lines 436 to 440
cy.createAnnotationTask(
taskName, labelName, attrName,
textDefaultValue, archiveName, false,
{ multiJobs: true, segmentSize: 2 },
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible I would propose to use headless creating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I remember there was a problem with attaching files to cypress requests, so for now ill stick to manual task creation

tests/cypress/e2e/features/ground_truth_jobs.js Outdated Show resolved Hide resolved
tests/cypress/e2e/features/ground_truth_jobs.js Outdated Show resolved Hide resolved
@bsekachev bsekachev merged commit 2c5bb69 into develop Feb 22, 2024
34 checks passed
@bsekachev bsekachev deleted the kl/add-ground-truth-jobs-table-test branch February 26, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants