Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event-related identifiers in cvat-core consistent #7482

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Feb 14, 2024

Motivation and context

These identifiers are inconsistent with the server-side code, and sometimes with each other (what's a logger and what's a log?), and it's breaking my brain.

Rename everything as follows:

  1. Event: the thing being logged.
  2. Logger: the thing doing the logging.
  3. Scope: the type of an event.

How has this been tested?

Manual testing.

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@SpecLad SpecLad marked this pull request as ready for review February 14, 2024 18:19
@SpecLad SpecLad requested a review from bsekachev as a code owner February 14, 2024 18:19
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Merging #7482 (022308b) into develop (6260232) will increase coverage by 0.01%.
The diff coverage is 98.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7482      +/-   ##
===========================================
+ Coverage    83.53%   83.54%   +0.01%     
===========================================
  Files          373      373              
  Lines        39693    39693              
  Branches      3718     3718              
===========================================
+ Hits         33157    33163       +6     
+ Misses        6536     6530       -6     
Components Coverage Δ
cvat-ui 79.43% <98.71%> (+0.02%) ⬆️
cvat-server 87.32% <ø> (+<0.01%) ⬆️

@bsekachev bsekachev merged commit 972a218 into cvat-ai:develop Feb 16, 2024
34 checks passed
@SpecLad SpecLad deleted the rename-event-ids branch September 30, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants