Record DB-related events only after changes are committed #7477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marishka17
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Why on_commit=True was not passed in the handle_delete function? https://github.dev/SpecLad/cvat/blob/d8a8c783d034163e6c21f71b4d1bc0416761c935/cvat/apps/events/handlers.py#L366-L379
There was a problem hiding this comment.
Oh, I missed it. Thanks for catching it; fixed now.
SpecLad
force-pushed
the
events-on-commit
branch
from
d8a8c78 to
3f84ea5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7477 +/- ##
===========================================
- Coverage 83.55% 83.54% -0.01%
===========================================
Files 375 375
Lines 39752 39756 +4
Branches 3734 3734
===========================================
Hits 33213 33213
- Misses 6539 6543 +4
|
Marishka17
approved these changes
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This is a small addendum to #7460, which I couldn't include in that PR, because it was blocked by #7430.
How has this been tested?
Manual testing.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.