Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open annotations guide automatically #7410

Merged
merged 25 commits into from
Feb 1, 2024
Merged

Open annotations guide automatically #7410

merged 25 commits into from
Feb 1, 2024

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 30, 2024 •
edited
Loading

Motivation and context

Also refactoring job's latest frame storing

Added opening a guide, using a link:

/tasks/<task_id>/jobs/<job_id>?openGuide

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev marked this pull request as ready for review January 30, 2024 11:52
@bsekachev bsekachev requested a review from azhavoro as a code owner January 30, 2024 11:52
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

Merging #7410 (c8a4582) into develop (bdd002a) will decrease coverage by 0.02%.
The diff coverage is 93.54%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7410      +/-   ##
===========================================
- Coverage    83.46%   83.44%   -0.02%     
===========================================
  Files          373      374       +1     
  Lines        39761    39779      +18     
  Branches      3721     3729       +8     
===========================================
+ Hits         33187    33195       +8     
- Misses        6574     6584      +10
Components Coverage Δ
cvat-ui 79.32% <93.54%> (-0.03%) ⬇️
cvat-server 87.24% <ø> (-0.01%) ⬇️

@bsekachev bsekachev requested a review from nmanovic as a code owner January 30, 2024 12:32
@bsekachev bsekachev requested review from klakhov and removed request for nmanovic January 30, 2024 12:40
@bsekachev
Copy link
Member Author

/check

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev
Copy link
Member Author

/check

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

❌ Some checks failed
📄 See logs here

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

❌ Some checks failed
📄 See logs here

@bsekachev
Copy link
Member Author

/check

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

❌ Some checks failed
📄 See logs here

klakhov
klakhov approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, from code perspective everything looks good. But there are a couple unstable tests not related to this patch 😥

@bsekachev
Copy link
Member Author

Yep, one possible fix for one of the tests is: #7423
But I continue investigating

@bsekachev
Copy link
Member Author

/check

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev
Copy link
Member Author

/check

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev
Copy link
Member Author

/check

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev bsekachev merged commit b7cc562 into develop Feb 1, 2024
34 checks passed
@bsekachev bsekachev deleted the bs/open_guide_automatically branch February 5, 2024 12:16
@cvat-bot cvat-bot bot mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakhov klakhov klakhov approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

@zhiltsov-max zhiltsov-max Awaiting requested review from zhiltsov-max

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsekachev @klakhov