Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LambdaQueue.get_jobs method #7231

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

Marishka17
Copy link
Contributor

Motivation and context

Since rq Job.fetch_many can return None we must explicitly check that job exists.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17 Marishka17 requested a review from SpecLad December 6, 2023 12:22
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #7231 (69338e1) into develop (a9c3425) will increase coverage by 0.04%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7231      +/-   ##
===========================================
+ Coverage    81.50%   81.54%   +0.04%     
===========================================
  Files          365      365              
  Lines        39261    39261              
  Branches      3631     3631              
===========================================
+ Hits         31999    32015      +16     
+ Misses        7262     7246      -16     
Components Coverage Δ
cvat-ui 75.41% <ø> (+0.08%) ⬆️
cvat-server 87.09% <100.00%> (ø)

@SpecLad SpecLad merged commit 571e622 into develop Dec 6, 2023
34 checks passed
@SpecLad SpecLad deleted the mk/fix_lambda_queue_get_jobs branch December 6, 2023 15:46
amjadsaadeh pushed a commit to amjadsaadeh/cvat that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants