[Helm] Don't try to install Traefik Middleware when Traefik is disabled #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7184 +/- ##
===========================================
- Coverage 81.48% 81.42% -0.06%
===========================================
Files 364 364
Lines 39877 39877
Branches 3702 3702
===========================================
- Hits 32494 32471 -23
- Misses 7383 7406 +23
|
|
Looks good, thanks. Could you add a changelog entry? |
ozen
force-pushed
the
fix/helm-traefik-middleware
branch
from
44cde5e to
1ddc82b
Compare
Sure, added. |
SpecLad
approved these changes
Nov 29, 2023
Merged
amjadsaadeh
pushed a commit
to amjadsaadeh/cvat
that referenced
this pull request
Dec 14, 2023
…ed (cvat-ai#7184) This PR is complementary to cvat-ai#7132. cvat-ai#7132 updated ingress templates to work with `traefik.enabled=false` and `ingress.enabled=true` values. However the templates in `templates/analytics/middlewares` path lead to creation of resources of kind `Middleware`, which is a Traefik CRD. Helm install fails if Traefik is not installed on the cluster. Changing the top-level conditional from `ingress.enabled` to `traefik.enabled` solves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is complementary to #7132.
#7132 updated ingress templates to work with
traefik.enabled=falseandingress.enabled=truevalues.However the templates in
templates/analytics/middlewarespath lead to creation of resources of kindMiddleware, which is a Traefik CRD. Helm install fails if Traefik is not installed on the cluster.Changing the top-level conditional from
ingress.enabledtotraefik.enabledsolves the issue.