Updated pillow, unlocked test #7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
requested review from
azhavoro,
SpecLad and
Marishka17
as code owners
bsekachev
changed the title
bsekachev
changed the title
bsekachev
commented
Nov 6, 2023
cvat/apps/engine/media_extractors.py
Outdated
| @@ -658,7 +658,7 @@ def save_as_chunk(self, images, chunk_path): | |||
| if has_exif_rotation(pil_image): | |||
| rot_image = ImageOps.exif_transpose(pil_image) | |||
| try: | |||
| if rot_image.format == 'TIFF': | |||
| if pil_image.format == 'TIFF': | |||
There was a problem hiding this comment.
rot_image.format is None after exif_transpose
It results to jpeg image saved with .tif filename
bsekachev
force-pushed
the
bs/update_pillow
branch
from
c122801 to
f5a9860
Compare
bsekachev
changed the title
bsekachev
changed the title
SpecLad
reviewed
Nov 23, 2023
bsekachev
changed the title
bsekachev
changed the title
bsekachev
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7100 +/- ##
===========================================
+ Coverage 82.93% 82.96% +0.02%
===========================================
Files 372 372
Lines 39576 39576
Branches 3688 3688
===========================================
+ Hits 32824 32835 +11
+ Misses 6752 6741 -11
|
bsekachev
commented
Dec 27, 2023
azhavoro
approved these changes
Dec 28, 2023
bsekachev
commented
Dec 28, 2023
bsekachev
commented
Dec 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.