-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hugo/docsy version #6791
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6791 +/- ##
===========================================
- Coverage 81.48% 81.44% -0.04%
===========================================
Files 364 364
Lines 39877 39877
Branches 3702 3702
===========================================
- Hits 32494 32479 -15
- Misses 7383 7398 +15
|
2bd4c19
to
3e836f9
Compare
3e836f9
to
3764986
Compare
@kirill-sizov , could you please look at problems with linters? |
With 118 it didn't even start when I tested. Please use the 110, which is recommended in the docsy 0.7.1 release and in this PR. I suppose something has been broken in the newer releases. |
There doesn't seem to actually be a Docsy update in this PR. |
Co-authored-by: Roman Donchenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK to me, but CI is broken.
@SpecLad, I fixed the problem, but another one appeared - pages for old versions depend on the old docsy and hugo, and their code is taken from specific tags. Need to think if we can change the building pipeline a little bit to checkout everything needed. |
🚫 Workflows has been canceled |
Fixed. Now several Hugo versions are used during the build. |
Newer hugo/docsy versions will allow to use several new features, such as tab groups and tags. - Updated Docsy to v0.7.1 - Updated Hugo to v0.110.0 - Fixed broken layout in the footer - Removed unnecessary breadcrumbs on the main page - Fixed some links in the footer - Updated the build pipeline to build both old and new releases correctly - Added VS Code tasks for docs build steps
Motivation and context
Newer versions will allow to use several new features, such as tab groups and tags.
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.