generate_image_file: don't hardcode the file format #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make much sense to encode the image as JPEG if the given file name is "image.png". Instead, let PIL select the format based on the requested file name.
Codecov Report
@@ Coverage Diff @@
## develop #6538 +/- ##
===========================================
+ Coverage 81.71% 81.75% +0.04%
===========================================
Files 337 337
Lines 38512 38525 +13
Branches 3545 3547 +2
===========================================
+ Hits 31470 31497 +27
+ Misses 7042 7028 -14
|
zhiltsov-max
approved these changes
Jul 22, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
It doesn't make much sense to encode the image as JPEG if the given file name is "image.png". Instead, let PIL select the format based on the requested file name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
It doesn't make much sense to encode the image as JPEG if the given file name is "image.png". Instead, let PIL select the format based on the requested file name.
This was originally a part of #6483, but it's not directly related to the topic of that PR, so I decided to submit it separately.
How has this been tested?
Unit tests.
Checklist
developbranch[ ] I have added a description of my changes into the CHANGELOG file[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.