Make the PyTorch adapter tests less likely to be disabled by accident #6386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, any kind of import error will disable the tests. This makes it far too easy to disable the tests accidentally by messing up the imports. Only disable the tests if PyTorch or torchvision are not found.
SpecLad
force-pushed
the
pytorch-accidental-disable
branch
from
60936dd to
f68d8f0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6386 +/- ##
========================================
Coverage 80.63% 80.63%
========================================
Files 332 332
Lines 38438 38438
Branches 6923 6923
========================================
Hits 30994 30994
Misses 7128 7128
Partials 316 316
|
zhiltsov-max
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Currently, any kind of import error will disable the tests. This makes it far too easy to disable the tests accidentally by messing up the imports.
Only disable the tests if PyTorch or torchvision are not found.
How has this been tested?
Manual testing with various artificially-introduced errors.
Checklist
developbranch[ ] I have added a description of my changes into the CHANGELOG file[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.