Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable coverage collection in quality reports worker #6341

Merged
merged 8 commits into from
Jun 21, 2023

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jun 20, 2023

Motivation and context

  • Added missing coverage collection in quality reports worker
  • Fixed invalid worker class in webhooks worker

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max zhiltsov-max requested a review from azhavoro as a code owner June 20, 2023 07:34
@zhiltsov-max zhiltsov-max force-pushed the zm/enable-coverage-for-quality-reports branch from f5590b8 to ecd75fe Compare June 20, 2023 07:35
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #6341 (3d8e2af) into develop (1a2365c) will increase coverage by 1.94%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6341      +/-   ##
===========================================
+ Coverage    79.76%   81.70%   +1.94%     
===========================================
  Files          321      321              
  Lines        37329    37329              
  Branches      6756     6756              
===========================================
+ Hits         29774    30501     +727     
+ Misses        7288     6520     -768     
- Partials       267      308      +41     
Components Coverage Δ
cvat-ui 77.13% <ø> (+0.03%) ⬆️
cvat-server 85.84% <ø> (+3.67%) ⬆️

@zhiltsov-max zhiltsov-max merged commit bb126d3 into develop Jun 21, 2023
@bsekachev bsekachev deleted the zm/enable-coverage-for-quality-reports branch June 23, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant