-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honey pot UI #6039
Honey pot UI #6039
Conversation
This reverts commit 3fb345e.
cvat-ui/src/containers/annotation-page/standard-workspace/objects-side-bar/objects-list.tsx
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/tag-annotation-workspace/frame-tags.tsx
Outdated
Show resolved
Hide resolved
...i/src/components/annotation-page/standard-workspace/objects-side-bar/objects-list-header.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/review/issues-aggregator.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/review/conflicts-aggregator.tsx
Outdated
Show resolved
Hide resolved
There is no reason to stay on "Create GT job" page after GT job is already created because several GT jobs can not be created. |
Ok, I see. Let's stick to the first option |
Okay, let's solve conflicts wait for Andrey review and I believe we can merge it |
Fixed
This menu is mutual for Jobs cards(on task and jobs pages), those buttons are used on Jobs Page mostly. I dont think we need 2 different menus
Fixed |
Ok, but job menus on the task page have the same problem - the "Go To" buttons are not needed there. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6039 +/- ##
===========================================
- Coverage 81.17% 80.12% -1.05%
===========================================
Files 322 331 +9
Lines 37782 38431 +649
Branches 6821 6923 +102
===========================================
+ Hits 30670 30794 +124
- Misses 6803 7328 +525
Partials 309 309
|
Motivation and context
Depends on #6204
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
Information about comments
These jobs still have to be annotated and reviewed by someone in the annotation team, it makes sense to treat their progress equally with other jobs.
Personally, I think without it, form looks too short and page becomes empty.
N/A
and no ability to download the report means the report doesn't exist yet. We need to wait for it to be computedCurrently deleted frames are marked for a task, so deleting frame in GT deletes it everywhere. It really doesn't make sence to support deleting frames in GT jobs, So lets disable that option for now
[ ] Broken top margin in the frame filter configuration dialog in the annotation pageLicense
Feel free to contact the maintainers if that's a concern.