-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reset of attributes when moving a task to a project #5764
Conversation
I see some strange behavior: try to create task with the following label configuration: task configuration``` [ { "name": "car", "id": 9, "color": "#2080c0", "type": "any", "attributes": [ { "id": 5, "name": "mark", "input_type": "select", "mutable": false, "values": [ "bmw", "audi", "fiat" ], "default_value": "bmw" } ] } ] ```Annotate some frames and set some non-default attributes, then create project with the following label configuration project configuration[ { "name": "car", "id": 10, "color": "#2080c0", "type": "any", "attributes": [ { "id": 6, "name": "mark", "input_type": "select", "mutable": false, "values": [ "ford", "honda", "volvo" ], "default_value": "ford" } ] } ] ```Then move annotated task into the project. It's questionable should we allow to move task in project if project has the same label with the same name attributes but with different attributes spec |
I think that the task with such attributes should not be moved. Expanded the check for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Fixed reset of attributes when moving a task to a project Steps to reproduce the bug: 1. Create a task with a couple of labels and attributes 2. Annotate several frames in the task. Attributes should have non-default value. 3. Create a project and copy the definition of labels with attributes 4. Move the task to the project. 5. Attributes should have default values after the action Co-authored-by: kirill-sizov <[email protected]>
Motivation and context
Steps to reproduce the bug:
How has this been tested?
Added REST API test
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.