Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVAT.js: Save and delete for shapes/tracks/tags #555

Merged
merged 12 commits into from
Jul 9, 2019
Merged

Conversation

bsekachev
Copy link
Member

No description provided.

@bsekachev bsekachev requested a review from nmanovic July 9, 2019 10:13
@bsekachev bsekachev changed the title CVAT.js: Save for shapes/tracks CVAT.js: Save and delete for shapes/tracks Jul 9, 2019
@bsekachev bsekachev changed the title CVAT.js: Save and delete for shapes/tracks CVAT.js: Save and delete for shapes/tracks/tags Jul 9, 2019
@@ -48,5 +48,6 @@
"indent": ["warn", 4],
"no-useless-constructor": 0,
"func-names": [0],
"valid-typeof": [0],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need the rule?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmanovic
In other case typeof works only with literals

@@ -179,10 +179,10 @@
}

async function logout() {
const { backendAPI } = window.cvat.config;
const host = window.cvat.config.backendAPI.slice(0, -7);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmanovic
backendAPI is host/api/v1
authorization url is host/auth

@nmanovic nmanovic merged commit 22bcf1c into develop Jul 9, 2019
@bsekachev bsekachev deleted the bs/cvat_dev_js_1 branch July 11, 2019 06:48
MultifokalHirn added a commit to signatrix/cvat that referenced this pull request Jul 22, 2019
* develop: (112 commits)
  fixed attribute processing in auto_annotation (cvat-ai#577)
  CVAT.js API Tests (cvat-ai#578)
  Fixed exception in attribute annotation mode (cvat-ai#571)
  CVAT.js API methods were implemented (cvat-ai#572)
  Dashboard components basic styles (cvat-ai#574)
  Handle invalid json labelmap file case correctly during create/update DL model stage. (cvat-ai#573)
  Upgrade Numpy to avoid Arbitrary Code Execution. Upgrade Django to avoid MitM (cvat-ai#575)
  Run functional tests for REST API during a build (cvat-ai#506)
  CVAT.js other implemented API methods and bug fixes (cvat-ai#569)
  CVAT.js implemented API methods and bug fixes (cvat-ai#564)
  added in handeling for openvino 2019 (cvat-ai#545)
  added in command line auto annotation runner (cvat-ai#563)
  Fixed PDF extractor syntax error (cvat-ai#565)
  Update README.md
  added in pdf extractor (cvat-ai#557)
  Basic dashboard components (cvat-ai#562)
  Saving of annotations on the server (cvat-ai#561)
  Code was devided by files (cvat-ai#558)
  CVAT.js: Save and delete for shapes/tracks/tags (cvat-ai#555)
  Fixed '=' to '==' for numpy in requirments (cvat-ai#556)
  ...

# Conflicts:
#	.gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants