Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented propagate backward #5355

Merged
merged 12 commits into from
Nov 29, 2022
Merged

Implemented propagate backward #5355

merged 12 commits into from
Nov 29, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 24, 2022

Motivation and context

Resolved #2998

image

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev added the enhancement New feature or request label Nov 24, 2022
@bsekachev bsekachev changed the title [WIP] Implemented propagate backward Implemented propagate backward Nov 25, 2022
@bsekachev bsekachev requested review from klakhov and removed request for azhavoro November 25, 2022 09:49
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this slider blinking should be fixed:
propagate1

Also what do you think about showing current from value in input(maybe we should disable it in such case) instead of keeping it empty?
image

@bsekachev
Copy link
Member Author

bsekachev commented Nov 28, 2022

@klakhov

Resolved comments.

Also what do you think about showing current from value in input(maybe we should disable it in such case) instead of keeping it empty?

I do not think we should disable it because we still should be able to modify them, slider and direction are updated automatically when you change empty input.

Finally I thought that we do not need two inputs here. Now there is only one.

@klakhov
Copy link
Contributor

klakhov commented Nov 29, 2022

I'm ok with changes. But I see one failed test with rotated images, feels its not related with this pr.

@bsekachev
Copy link
Member Author

@klakhov

OMG, this is already the third unstable test in this PR.
I tried to fix it making assumption that reason is the same like for previous...

@bsekachev bsekachev merged commit 460df33 into develop Nov 29, 2022
@bsekachev bsekachev deleted the bs/propagate_backward branch December 2, 2022 10:24
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate to frame before
2 participants