cvat-sdk: make sure to redraw the progress bar after use #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqdm does not necessarily redraw the progress bar after every update, and without the call to `refresh` it might not update it to the final state. I discovered this while writing a test in which the progress bar is updated in chunks, and the last chunk is smaller than the previous ones.
|
I changed it to |
SpecLad
changed the title
4 tasks
nmanovic
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tqdm does not necessarily redraw the progress bar after every update, and without the call to
closeit might not update it to the final state.Motivation and context
I discovered this while writing a test in which the progress bar is updated in chunks, and the last chunk is smaller than the previous ones.
How has this been tested?
Indirectly through the test I'm about to add to #5204.
Checklist
developbranch[ ] I have added a description of my changes into CHANGELOG file[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.