Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed changing label color on canvas #5045

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Fixed changing label color on canvas #5045

merged 3 commits into from
Oct 5, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Oct 5, 2022 •
edited
Loading

Motivation and context

Resolved #4966

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev mentioned this pull request Oct 5, 2022
Closed
7 tasks
@bsekachev bsekachev changed the title [WIP] Fixed changing label color on canvas Fixed changing label color on canvas Oct 5, 2022
@bsekachev bsekachev requested a review from klakhov October 5, 2022 07:29
@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

klakhov
klakhov reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch works fine for me 😄

cvat-canvas/src/typescript/canvasView.ts Show resolved Hide resolved
@bsekachev bsekachev merged commit 7850f1e into develop Oct 5, 2022
@bsekachev bsekachev deleted the bs/fixed_changing_label_color branch October 5, 2022 13:53
@nmanovic nmanovic mentioned this pull request Nov 1, 2022
Closed
@sebastiansimyonghwee
Copy link

Color is still not changed for Points, when using shortcut key to change the label.

@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakhov klakhov klakhov approved these changes

@nmanovic nmanovic Awaiting requested review from nmanovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shape color in canvas is not changed after objects label selection
3 participants
@bsekachev @sebastiansimyonghwee @klakhov