Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host schema auto-detection in SDK #4910

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Sep 6, 2022

Motivation and context

This PR simplifies usage of SDK/CLI in simple cases, when CVAT is deployed with default parameters. Now, we don't need to specify schema or port in these cases.

  • Added schema autodetection in SDK
  • SDK uses default http (80) and https (443) ports for connections
  • Removed the --https CLI arg

How has this been tested?

Unit tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max zhiltsov-max changed the title Add host schema auto-detection in SDK [WIP] Add host schema auto-detection in SDK Sep 6, 2022
@zhiltsov-max zhiltsov-max changed the title [WIP] Add host schema auto-detection in SDK Add host schema auto-detection in SDK Sep 6, 2022
# SPDX-License-Identifier: MIT


class CvatSdkException(Exception):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will prefer to avoid Cvat name.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 7218f4e into develop Sep 6, 2022
@nmanovic nmanovic deleted the zm/remove-https-arg-in-cli branch September 6, 2022 19:33
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants