-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Oracle OCI Buckets #4876
Conversation
ec05070
to
3c5b687
Compare
3c5b687
to
0c34934
Compare
@rodrigoberriel , thanks for the contribution! @Marishka17 , do you see any problems with PR? For me it looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodrigoberriel, Hi, thanks for the contribution!
@nmanovic, I don't really like this solution, because every time this problem occurs with a new provider with AWS S3 compatible API, it will be necessary to update these limits. But for now, let's keep it like that.
Hi @rodrigoberriel, Can you help me in using OCI cloud storage bucket in cvat as a storage provider, I am not sure which option to choose and what is the exact process to link oci storage. I Also tried to find any documentation for the same but no luck. Can you provide an example? Thanks |
@avinash31d OCI, like many others, offers S3-compatible endpoints for their buckets. Therefore, you just have to
That's it. |
Currently, CVAT only does not support Oracle OCI Buckets because of the lenght limit of the access and secret keys, as discussed in #4783. This simple PR increases the limit of the access and secret keys to the current lenghts of the Oracle OCI keys.
Motivation and context
Closes #4783.
Related: #4582, #4584.
How has this been tested?
I updated the CVAT locally and checked that I could successfully add and use Oracle OCI Buckets. We have been using Oracle OCI Buckets in CVAT for weeks now.
Checklist
develop
branchI have added tests to cover my changesI have increased versions of npm packages if it is necessary (cvat-canvas, cvat-core, cvat-data and cvat-ui)License
Feel free to contact the maintainers if that's a concern.