Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added track removing confirmation #4846

Merged
merged 6 commits into from
Aug 29, 2022
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Aug 25, 2022

Motivation and context

image

Resolved #4844

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev
Copy link
Member Author

Hi @AlexeyAlexeevXperienceAI

Could you please look at the PR?

@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

❌ Some checks failed
📄 See logs here

@nmanovic
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

❌ Some checks failed
📄 See logs here

@nmanovic
Copy link
Contributor

@bsekachev , looks good for me. But by a reason we have a failed test. I'm sure it isn't connected with your changes.

@nmanovic
Copy link
Contributor

@kirill-sizov , could you please help us to investigate why we have the problem with REST APi tests?

@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022

❌ Some checks failed
📄 See logs here

@bsekachev
Copy link
Member Author

@kirill-sizov

Run actions/download-artifact@v3
Starting download for cvat_server
Error: Unable to find an artifact with the name: cvat_server

Do you have any ideas?

@sizov-kirill
Copy link
Contributor

sizov-kirill commented Aug 29, 2022

@kirill-sizov

Run actions/download-artifact@v3
Starting download for cvat_server
Error: Unable to find an artifact with the name: cvat_server

Do you have any ideas?

Yes, I see the problem, will fix it in separate PR

But if talk about tests, they are all passed. Failed e2e test with connected file share not related with this PR (#4862)

@bsekachev
Copy link
Member Author

@nmanovic
Could you please merge the PR?

@bsekachev bsekachev merged commit 2c3341a into develop Aug 29, 2022
@bsekachev bsekachev deleted the bs/remove_track_confirmation branch August 29, 2022 16:55
@nmanovic nmanovic mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To make a track removing more explicit
4 participants